2 ms·
> I am then left with figuring out which changes are related to the bug fix and what is related to the cleanup. Hmm. That has never been an issue for me in pra
by goalieca 6y ago
> I am then left with figuring out which changes are related to the bug fix and what is related to the cleanup.
Hmm. That has never been an issue for me in practice unless they go way too far with the refactoring. Usually it’s me who suggests cleanup for defensive coding reasons because the bug is often a coding issue.
- hinkley 6y agoPeople frustrate me by taking the short view of these things. Bigger refactorings and architectural changes usually require tracing the tendrils of an assumption out through the code. It’s not a matter of “can they figure it out,” it’s a matter of doing that in ten places and still somehow hold the other three bits of critical data in short term memory. If this path isn’t fruitful then there are five other theories to try so it’s not particularly amenable to writing it down. It’s flow state depth first search, and the crappy non-idiomatic code is ruining the flow. People always try to deflect based on some intelligence argument. I’m not trying to understand your code, I’m trying to understand something you missed. This isn’t about intelligence, it’s about wisdom.