4 ms·
>because they only solve the problem that the PR submitter needs solved right now. This is something that can lead to angry interactions between maintainers an
by throwawaywrench 6y ago
>because they only solve the problem that the PR submitter needs solved right now.
This is something that can lead to angry interactions between maintainers and pull request raisers. Never mind adding technical debt, pull requests can outright break uses cases they don't care about in order to implement the single use case they do care about.
raiser: "Merge my PR. It fixes this issue."
maintainer: "It fixes this single issue but you've broken this for everyone else."
raiser: table flip
- sergeykish 6y agoWhy? Just use own fork for a while. PR is sharing fix with others, it is visible even if not merged.
- rusticpenn 6y agoA good test strategy would fix the problem. "Your PR fails all these tests, so can you make them all work before submitting the request?"
- throwawaywrench 6y agoDefinitely. You just need to keep an eye out for people removing failing tests because they think they are irrelevant :|