3 ms·
Stopping the world after 72h of CI fails seems like a dangerous decision, especially if you have a large team working on a monorepo. Note that fails can easily
by stkdump 6y ago
Stopping the world after 72h of CI fails seems like a dangerous decision, especially if you have a large team working on a monorepo. Note that fails can easily 'pile up' and the 72h are not necessarily all caused by the same change. I would probably get paranoid, feeling the constant pressure not to be part of the cause for such an occourance.
- rendall 6y agoYes, I didn't understand this. I've even been a part of workflows that halt all subsequent PRs until the CI tests pass, and I still don't understand the situation this is designed to prevent. Why not simply disallow the PR to merge unless CI passes? Why stop all integrations? There must be something I'm missing. Edit: I think I get it. Normally PRs to Github.com non-enterprise go through as normal. 45 minutes later, after that merge, the 2 expensive Enterprise CI tests complete and that's when the developer gets the 72 hour timer. The dev has the option of reverting their change and trying again.