3 ms·

It is not the case, and all that has happened is a removal: https://github.com/ytdl-org/youtube-dl/commit/1fb034d029c8b7feafe45f64e6a0808663ad315e https://githu

• boomboomsubban 6y ago
  That commit details the replacement of the music videos with a generic test video, exactly what I said. I'm unsure how it is supposed to show it is not the case.
  • crtasm 6y ago
    Incorrect. There's a single green line that has an alteration to replace a music video ID "UxxajLWwzqY" in a test case that actually only makes use of ID "BaW_jenozKc" ("Use the first video ID in the URL"). The removed "Test generic use_cipher_signature video (#897)" case did make use of ID UxxajLWwzqY.
    • boomboomsubban 6y ago
      I see what you mean, but the extractor file still features how to deal with videos containing the cipher, all that was removed was the tests. Testing the generic cipher video may have been ruled unnecessary as it's universal.
      • crtasm 6y ago
        That's the partial win here - repo restored with tests referencing the RIAA related videos removed but the code dealing with the rolling cipher itself still intact. And next time youtube makes one of their frequent changes to their website the extractor will break in some way. Somebody will work to fix it and make use of the same tests, only now some of them won't be in the public codebase.
        • boomboomsubban 6y ago
          Except we haven't established whether there was anything special about those videos at all
          • crtasm 6y ago
            But on the other hand there is always an omelette to whisk.