4 ms·

Can you comment on individual lines of a changeset in an email and reply to such comments separately, and then see such conversations in the context of the diff

by hvis 6y ago

Can you comment on individual lines of a changeset in an email and reply to such comments separately, and then see such conversations in the context of the diff? And then mark them as resolved when that happens? Can you read those discussions later in a "flat" presentation without scrolling through emails one-by-one? These are some of the killer features of the PR/MR Github/Gitlab workflows. To clarify, I'm talking about steps 4-7 here: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request https://docs.github.com/en/free-pro-team@latest/github/colla... As well as the "Resolving conversations" section.

ddevault 6y ago
>Can you comment on individual lines of a changeset in an email and reply to such comments separately, and then see such conversations in the context of the diff? And then mark them as resolved when that happens? Yes, except for the last bit. Unlike GitHub/GitLab you can also respond to several comments at once. >Can you read those discussions later in a "flat" presentation without scrolling through emails one-by-one? I don't know what this means.
- comex 6y ago
  Judging from my GitHub experience, I think they mean seeing, under each chunk of code, the whole conversation thread pertaining to that chunk. In other words, where a standard mailing list format looks like: Person 1 > Chunk of code 1 Comment > Chunk of code 2 Comment Person 2 > Chunk of code 1 Comment > Chunk of code 2 Comment they want a view like: Chunk of code 1 Person 1 Comment Person 2 Comment Chunk of code 2 Person 1 Comment Person 2 Comment
  - ddevault 6y ago
    Yeah, we have a view like that.
    - comex 6y ago
      Out of curiosity, do you have an example of what it looks like? (I checked several patches on https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches but couldn't find anything with line-by-line discussion.)
      - ddevault 6y ago
        Here's a simple example: https://lists.sr.ht/~emersion/mrsh-dev/patches/3449 https://lists.sr.ht/~emersion/mrsh-dev/patches/3449
        hvis 6y ago
        Thanks for the reply. It's more than I expected (even if the UI and the lack of interactivity inside the browser are still a problem for me). Looking forward to experiencing it in practice someday. Maybe Emacs will finally migrate off Debbugs.
        ddevault 6y ago
        You should go ask them! There's an ongoing discussion about it on the mailing list right now.
        hvis 6y ago
        I'm on the mailing list ;-) The issue is brought up repeatedly, but there's no real movement right this moment (or for the last several months, really). There are several proponents of SourceHut thanks to its email-based workflows and (apparently?) LibreJS compatibility. But none are passionate enough to push for it, thus far, and do the work required. As opposed to, say, advocates of Gitlab (which got effectively banned by a long list of requirements, alas).

by hvis 6y ago

ddevault 6y ago

>Can you comment on individual lines of a changeset in an email and reply to such comments separately, and then see such conversations in the context of the diff? And then mark them as resolved when that happens? Yes, except for the last bit. Unlike GitHub/GitLab you can also respond to several comments at once. >Can you read those discussions later in a "flat" presentation without scrolling through emails one-by-one? I don't know what this means.

comex 6y ago
Judging from my GitHub experience, I think they mean seeing, under each chunk of code, the whole conversation thread pertaining to that chunk. In other words, where a standard mailing list format looks like: Person 1 > Chunk of code 1 Comment > Chunk of code 2 Comment Person 2 > Chunk of code 1 Comment > Chunk of code 2 Comment they want a view like: Chunk of code 1 Person 1 Comment Person 2 Comment Chunk of code 2 Person 1 Comment Person 2 Comment
- ddevault 6y ago
  Yeah, we have a view like that.
  - comex 6y ago
    Out of curiosity, do you have an example of what it looks like? (I checked several patches on https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches but couldn't find anything with line-by-line discussion.)
    - ddevault 6y ago
      Here's a simple example: https://lists.sr.ht/~emersion/mrsh-dev/patches/3449 https://lists.sr.ht/~emersion/mrsh-dev/patches/3449
      - hvis 6y ago
        Thanks for the reply. It's more than I expected (even if the UI and the lack of interactivity inside the browser are still a problem for me). Looking forward to experiencing it in practice someday. Maybe Emacs will finally migrate off Debbugs.
        ddevault 6y ago
        You should go ask them! There's an ongoing discussion about it on the mailing list right now.
        hvis 6y ago
        I'm on the mailing list ;-) The issue is brought up repeatedly, but there's no real movement right this moment (or for the last several months, really). There are several proponents of SourceHut thanks to its email-based workflows and (apparently?) LibreJS compatibility. But none are passionate enough to push for it, thus far, and do the work required. As opposed to, say, advocates of Gitlab (which got effectively banned by a long list of requirements, alas).