4 ms·
Hi again, author here! I am so pleased to see your interest, thanks a lot! I have addressed a few points here, and just updated the repo, so please keep that i
by boramalper 6y ago
Hi again, author here!
I am so pleased to see your interest, thanks a lot! I have addressed a few points here, and just updated the repo, so please keep that in mind while browsing the comments:
1. Some people found the README a bit arrogant/bratty --- which I agree, sorry! --- so I have edited it.
2. Some people found it clickbait-y it says Python whereas there are two C libraries (uvloop, and hiredis) for heavy-lifting the event loop and parsing (respectively.) I have added this fact as a disclaimer in the README, and ultimately it is up to you to decide whether that counts as cheating or not. :)
3. I have addressed some major correctness issues too (#12) but it is not 100% correct still.
4. This is a proof-of-concept that I wrote in a day (+ spent today fixing some bugs) that you are comparing to an 11 years old industry-grade software. =) Don't take the experiment too seriously!
Kindly,
Bora
- tbenst 6y agoThanks for creating and sharing this! Always easier to criticize than create. I for one think your code reads as quite pythonic. Using convenient python wrappers for c libraries is the raison d'être for python in the first place. See numpy, pytorch, ...
- chrfrasco 6y agoI hope you didn't take too many of these comments to heart. You unfortunately got the standard HN comment section treatment – a delightful mix of nitpicking, assuming bad intent, and completely missing the point. I also hope you continue to share things on the internet – it's far easier to criticise than it is to create.