4 ms·
I recently had a coworker point out to me a grammatical error I keep repeating, flush vs flesh, that he had reminded me of a year ago. I recently pointed out t
by derekbreden 6y ago
I recently had a coworker point out to me a grammatical error I keep repeating, flush vs flesh, that he had reminded me of a year ago.
I recently pointed out to a different coworker some whitespace inconsistency in a pull request in a similar fashion as I had pointed out a while back.
In digging deeper into both situations where I was the reporter or the reportee, the issue came down to legitimate lack of agreement on whether it was indeed a mistake.
- vonseel 6y agoYea, unless you're professional writers, and I don't mean coders, that's not the right kind of things to focus on in pull requests. I mean, if someone happens to be great at code but really terrible at English, like you can't imagine they passed high school grammar, maybe it's a good idea to help them improve. But the average college educated developer writes well enough to write succinct and readable code comments and documentation. Or should be able to.
- mixmastamyk 6y agoEven when we learn from a mistake it may still happen in the future. Hopefully we have reduced its frequency but it can still happen. For example, I sometimes write "too be honest…". I've known it is wrong for decades, but occasionally am still not able to see it. Still happens about one out of every fifth time.
- FanaHOVA 6y ago> I recently pointed out to a different coworker some whitespace inconsistency in a pull request in a similar fashion as I had pointed out a while back. Just use transformers :)