3 ms·

What I find amusing is that the code for reading that .pam_environment file is broken: https://git.launchpad.net/ubuntu/+source/accountsservice/tree/debian/patc

• asddubs 6y ago
  it would be 50 byte regions of any given line, right?
  • gcbirzan 6y ago
    They don't even take that into account, which is another issue. They just look for those two strings in any 50 byte block, so if you have FOO=LANG\n that'll count as having LANG set.
• GoblinSlayer 6y ago
  fgets reads a line, not 50 chars
  • eMSF 6y ago
    fgets reads until the next newline character, or at most size-1 characters. For arbitrary inputs, a loop like that sets ret to TRUE if the given prefix (i.e. LANG) is found at the beginning of any line, i.e. starting at the first column – or for longer lines, if it is found starting at the 50th column (or 99th column, etc.) I don't know enough of the format of the .pam_environment file to tell whether that may lead to unexpected results.