3 ms·
Looks like my flow. One thing I do wonder, how do people deal with the tests and the time it takes for a PR to be approved (including tests, discussion, people
by teekert 6y ago
Looks like my flow. One thing I do wonder, how do people deal with the tests and the time it takes for a PR to be approved (including tests, discussion, people in different time zones)?
I often have interdependent branches (large pieces of related work chopped into small tasks) and take my previous branch along in my new one, this leads to an order in PRs sometimes when a big tasks is followed by a small/fast one. Sometimes I think, come on team, pick up my PR!
- joombaga 6y agoMy PRs sometimes get queued up like that too. Right now I'm waiting to merge an OS upgrade behind a single python package upgrade. I try to anticipate it in sprint planning and do reviews while I'm waiting for reviews.
- Vinnl 6y agoI don't often have that much interdependent work, but if I do, I usually just base the new PR off the old one, and rebase them after the first one is merged. Worst I've experienced is four of those PRs in a row, which wasn't too bad.