3 ms·
What about actually including a clause about pushing your changes upstream because from my recent HN readings, that clause is not present.
by 2Gkashmiri 6y ago
What about actually including a clause about pushing your changes upstream because from my recent HN readings, that clause is not present.
- wolfgke 6y agoThe source code has to be provided. From this, one can easily generate a diff. The only thing that such a clause will do is having to inform the original maintainer of this. But I don't think that such a clause is a good idea: very often these internal modifications are not of the required quality. Also, I can easily imagine that some projects might drown in low-quality upstream pushes.
- 2Gkashmiri 6y agoBug fixes is what I am thinking about.
- wolfgke 6y agoIt is often not clear what is a bug and what is "unexpected/surprising (but 'correct') behavior". Also, many bug fixes of authors that don't have a good understanding of the code cause lots of additional regressions or don't fit the original architecture of the software well.