3 ms·
> They patched out the checks for rebar.lock files from the 3rd party Erlang build system. Oh ffs really? Yeah, that's the kind of hijinks that leave you scra
by carapace 6y ago
> They patched out the checks for rebar.lock files from the 3rd party Erlang build system.
Oh ffs really? Yeah, that's the kind of hijinks that leave you scratching your head. Thanks for the head's up.
- k32 6y ago> Oh ffs really? Yes, really. This PR partially reverted this behavior (or rather made it less intrusive): https://github.com/NixOS/nixpkgs/pull/54115/files https://github.com/NixOS/nixpkgs/pull/54115/files , but from there you can easily track "rebar3 hermecity patch", which had introduced it.
- carapace 6y agoEgad!
- soraminazuki 6y agoNo, the commenter is grossly misrepresenting the facts here, as is the case with every other point being made in that same comment. The patch in question disables the ability to fetch packages from online sources, requiring you to specify the URL of the required packages and its hash beforehand. Plus, it's not even meant for general use and instead is meant to help with packaging for Nix. For general use, you can very easily use the unmodified build instead.
- carapace 6y agoCheers I'll admit (although it annoys me) that I couldn't follow what was going on there. Nix x Erlang's gnarly build system seems like complexity junkie crack to me, but then I'm getting older.
- soraminazuki 6y agoI too initially assumed the commenter was being honest, and it took me a while going through code, commit history, and GitHub issues to realize that this wasn't the case.
- k32 6y ago> Erlang's gnarly build system It's actually fine, thanks for a remark.
- k32 6y ago> requiring you to specify the URL of the required packages and its hash beforehand. ...a different hash. You see, I naively think that a checksums should not be overwritten when they doesn't match.
- soraminazuki 6y agoThat's not what I said. It's not about replacing hashes.