4 ms·
The biggest insight in that thread is how big of a jerk "PublicByte" is. I sure hope I never have th misfortune of working with that person or anyone like him.
by seattle_spring 6y ago
The biggest insight in that thread is how big of a jerk "PublicByte" is. I sure hope I never have th misfortune of working with that person or anyone like him.
- gonzo41 6y agoYeah that person really dialed things up to 11 there. But I think it's a tone that stems from a legitimacy thing with javascript having a super low barrier to entry.
- hn_throwaway_99 6y agoDid you actually read the function in this library. While yes it's a single line I'm convinced that anyone who thinks this is an "obvious" implementation hasn't actually read the code.
- gonzo41 6y agoActually I did read the function, and I thought about the cycles that toString.call(arr) == '[object Array]' costs.
- hn_throwaway_99 6y agoIs there some other implementation you think would work?
- seattle_spring 6y ago... which only gets called if the native implementation of `isArray` is not found.
- karmakaze 6y agoES5 is a low requirement. I'd rather use a lib that did a better job than one that returns true for the string '[object Array]' or have the app decide for itself what its own types are.
- amadeuspagel 6y agoYeah, github desperately needs moderation. Maintainers should be able to flag issues, and prevent people who more then x flags from filing issues.
- jchook 6y agoSome seriously relevant psychoanalysis of this behavior in this article (also on HN front page) about toxic workplaces: https://articles.tilt365.com/identify-destructive-leadership-patterns/ https://articles.tilt365.com/identify-destructive-leadership...
- disown 6y agoPlease use harrassment free language. You've broken a few comment rules. Can you review the community guidelines and refrain from breaking the rules? https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html