3 ms·
It's not either/or. We use them in case a developer forgets to run them, or hasn't set their environment up properly or similar.
by cameronh90 6y ago
It's not either/or. We use them in case a developer forgets to run them, or hasn't set their environment up properly or similar.
- raziel2p 6y agoThat's why you make it part of the CI pipeline and require it to pass before merging, making it impossible to forget. The only reason you'd release a tool like this as a github integration and not an open source library (optionally with a CLI tool) is that you want to get money from it - nothing wrong with that, but that is very much an either/or question.
- rikatee 6y agoBlocking the build works well for things that are boolean "correct" or "not correct", but some things are not are just "food for thought". Django doctor points out when something looks like it can be improved, but that's ultimately up to the dev to take the advice. It's "have you thought of..." rather than "you must do this". With the advantage that if the dev likes the advice, all they need to do is click "commit"