4 ms·
It looks like `micmute_led_set` does exactly this.
by slezyr 6y ago
It looks like `micmute_led_set` does exactly this.
- LeonM 6y agoI don't think it does. It doesn't look like the method is actually using the 'brightness' argument. It's just reading the ACPI status bits to update the current state. It doesn't set anything. static int micmute_led_set(struct led_classdev *led_cdev, enum led_brightness brightness) { acpi_status status; status = acpi_evaluate_object(NULL, ACPI_PRIVACY_EC_ACK, NULL, NULL); if (ACPI_FAILURE(status)) { dev_err(led_cdev->dev, "Error setting privacy audio EC ack value: %d\n",status); return -EIO; } return 0; }
- slezyr 6y agoI've assumed that there is a kernel voodoo magic happens, but it seems that the reviewer is also confused by this. https://lore.kernel.org/lkml/20201104014915.45tbmnrqvccbrd2k@srcf.ucam.org/#t https://lore.kernel.org/lkml/20201104014915.45tbmnrqvccbrd2k... Might be copy/paste from another driver or they will implement it later.