12 ms·

Call me a skeptic but the code isn't very confidence inspiring https://github.com/dahlia-os/system-recovery/commit/49336659151ddcf5113b649e5eda522f9ff1bd43 htt

by zeusk 6y ago

Call me a skeptic but the code isn't very confidence inspiring https://github.com/dahlia-os/system-recovery/commit/49336659151ddcf5113b649e5eda522f9ff1bd43 https://github.com/dahlia-os/system-recovery/commit/49336659...

ampdepolymerase 6y ago
Forgetting to run the formatter before git committing is not that big of a deal.
- monkin 6y ago
  “asdasdasd”
  - est31 6y ago
    Actually it's pretty common: https://github.com/search?q=asdasd&type=commits https://github.com/search?q=asdasd&type=commits
    - skuba 6y ago
      A
    - deleted 6y ago
      [deleted]
- laumars 6y ago
  Indeed. However what is more telling is failing to set up git commit hooks (so one doesn’t need to remember running a formatter) and then randomly mashing the keyboard for the commit message.
  - deleted 6y ago
    [deleted]
- visarga 6y ago
  Or maybe it's that the code looks like plain HTML instead of being organised by components.
skavi 6y ago
These guys used to be on the Fuchsia subreddit fairly frequently. They were definitely far from experienced or professional. IIRC, the founder is very young and was very much a beginner to OS development.
- est31 6y ago
  Usually hn is very positive towards young folks doing stuff, and doesn't measure it by the bar that older people get measured by. Why is this different this time? Also even then, you'll probably find people doing mistakes, committing hacks, etc all the time. It's like complaining that the initial Linux release doesn't support x86... Linus didn't write it for x86 originally.
  - skavi 6y ago
    I didn’t mean for my comment to be an insult. It is as close to the truth as I remember, and was offered as an explanation for the potentially low code quality mentioned earlier in the thread.
    - nmcain 6y ago
      It definitely isn't an insult :). I attempt to keep more quality and professionalism now, the earlier days of the project were, as they say, "turbulent". I do enjoy seeing criticism, as it guides us and often shows us points to improve, especially the code quality, which is being completely overhauled as we progress.
  - pengaru 6y ago
    > It's like complaining that the initial Linux release doesn't support x86... Linus didn't write it for x86 originally. What the hell is this nonsense? Linus was working on a terminal program for his 386 with native x86 task switching and that's the origin story of Linux. It's clearly recorded on the wikipedia page for the kernel, and he speaks to this in Just For Fun IIRC.
    - est31 6y ago
nmcain 6y ago
Thankfully that's just around for layout reference, working with the Process class was absolutely infuriating. I have made more effort since then to be more verbose and keeping the code up to a decent quality.

by zeusk 6y ago

ampdepolymerase 6y ago

Forgetting to run the formatter before git committing is not that big of a deal.

monkin 6y ago
“asdasdasd”
- est31 6y ago
  Actually it's pretty common: https://github.com/search?q=asdasd&type=commits https://github.com/search?q=asdasd&type=commits
  - skuba 6y ago
    A
  - deleted 6y ago
    [deleted]
laumars 6y ago
Indeed. However what is more telling is failing to set up git commit hooks (so one doesn’t need to remember running a formatter) and then randomly mashing the keyboard for the commit message.
- deleted 6y ago
  [deleted]
visarga 6y ago
Or maybe it's that the code looks like plain HTML instead of being organised by components.

skavi 6y ago

These guys used to be on the Fuchsia subreddit fairly frequently. They were definitely far from experienced or professional. IIRC, the founder is very young and was very much a beginner to OS development.

est31 6y ago
Usually hn is very positive towards young folks doing stuff, and doesn't measure it by the bar that older people get measured by. Why is this different this time? Also even then, you'll probably find people doing mistakes, committing hacks, etc all the time. It's like complaining that the initial Linux release doesn't support x86... Linus didn't write it for x86 originally.
- skavi 6y ago
  I didn’t mean for my comment to be an insult. It is as close to the truth as I remember, and was offered as an explanation for the potentially low code quality mentioned earlier in the thread.
  - nmcain 6y ago
    It definitely isn't an insult :). I attempt to keep more quality and professionalism now, the earlier days of the project were, as they say, "turbulent". I do enjoy seeing criticism, as it guides us and often shows us points to improve, especially the code quality, which is being completely overhauled as we progress.
- pengaru 6y ago
  > It's like complaining that the initial Linux release doesn't support x86... Linus didn't write it for x86 originally. What the hell is this nonsense? Linus was working on a terminal program for his 386 with native x86 task switching and that's the origin story of Linux. It's clearly recorded on the wikipedia page for the kernel, and he speaks to this in Just For Fun IIRC.
  - est31 6y ago

nmcain 6y ago

Thankfully that's just around for layout reference, working with the Process class was absolutely infuriating. I have made more effort since then to be more verbose and keeping the code up to a decent quality.