4 ms·

Maybe GitLab needs an option to disable external linking, and filter any comment that contains an external link automatically

csdreamer7 6y ago
Or a nofollow option (add rel=nofollow)
- dnsmichi 6y ago
  That's a great idea. We have discussed ways of getting a trust level, and enable this for specific groups. Discourse uses the same system for preventing spam. "Good" bots detect the rel=nofollow and do not come back. See my proposal here: https://gitlab.com/gitlab-org/gitlab/-/issues/14156#note_258252735 https://gitlab.com/gitlab-org/gitlab/-/issues/14156#note_258...
  - dnsmichi 6y ago
    Iterating on my original thought, here is a smaller feature request for self-hosted GitLab instances. This can help GitLab.com too: https://gitlab.com/gitlab-org/gitlab/-/issues/273618 https://gitlab.com/gitlab-org/gitlab/-/issues/273618
    - coder543 6y ago
      I still think an even better path to success is to allow entirely disabling linking for non-admins. Google no longer treats "nofollow" as strongly as it used to: https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html https://webmasters.googleblog.com/2019/09/evolving-nofollow-...
      - dnsmichi 6y ago
        Thanks for sharing, I have added it to the issue, maybe you want to join the discussion there :) https://gitlab.com/gitlab-org/gitlab/-/issues/273618#note_438625502 https://gitlab.com/gitlab-org/gitlab/-/issues/273618#note_43... Just so that I can follow - URLs posted by non-admins should not render as HTML URLs at all? Wouldn't that be quite limiting for OSS project members for example?
        coder543 6y ago
        My opinion on the topic isn't definitive by any means, but I think a lot of projects would do just fine without allowing arbitrary hyperlinks to be added by non-admins. I think being able to link to related issues and link into the code is still important, for example. It's certainly a trade off, but spammers want it to be rendered as a link.

csdreamer7 6y ago

Or a nofollow option (add rel=nofollow)

dnsmichi 6y ago
That's a great idea. We have discussed ways of getting a trust level, and enable this for specific groups. Discourse uses the same system for preventing spam. "Good" bots detect the rel=nofollow and do not come back. See my proposal here: https://gitlab.com/gitlab-org/gitlab/-/issues/14156#note_258252735 https://gitlab.com/gitlab-org/gitlab/-/issues/14156#note_258...
- dnsmichi 6y ago
  Iterating on my original thought, here is a smaller feature request for self-hosted GitLab instances. This can help GitLab.com too: https://gitlab.com/gitlab-org/gitlab/-/issues/273618 https://gitlab.com/gitlab-org/gitlab/-/issues/273618
  - coder543 6y ago
    I still think an even better path to success is to allow entirely disabling linking for non-admins. Google no longer treats "nofollow" as strongly as it used to: https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html https://webmasters.googleblog.com/2019/09/evolving-nofollow-...
    - dnsmichi 6y ago
      Thanks for sharing, I have added it to the issue, maybe you want to join the discussion there :) https://gitlab.com/gitlab-org/gitlab/-/issues/273618#note_438625502 https://gitlab.com/gitlab-org/gitlab/-/issues/273618#note_43... Just so that I can follow - URLs posted by non-admins should not render as HTML URLs at all? Wouldn't that be quite limiting for OSS project members for example?
      - coder543 6y ago
        My opinion on the topic isn't definitive by any means, but I think a lot of projects would do just fine without allowing arbitrary hyperlinks to be added by non-admins. I think being able to link to related issues and link into the code is still important, for example. It's certainly a trade off, but spammers want it to be rendered as a link.