3 ms·
We have seen some of this; Dropbox has a macro that lets them turn off checks with a feature flag, for example, because it had a noticeable impact.
by steveklabnik 6y ago
We have seen some of this; Dropbox has a macro that lets them turn off checks with a feature flag, for example, because it had a noticeable impact.
- ATsch 6y agoAh, that's interesting, I assume this is the link: https://dropbox.tech/infrastructure/lossless-compression-with-brotli https://dropbox.tech/infrastructure/lossless-compression-wit... Shows a significant improvement in compression code and some examples of checks that can't be elided. I guess this makes sense because it's pretty much the worst case scenario for bounds check impact. I can still personally say that every time I've blamed rust's bounds checks, I was wrong. EDIT: neither the unsafe flag nor the macro appear to be present in https://github.com/dropbox/rust-brotli/ https://github.com/dropbox/rust-brotli/ anymore today, removed some time in 2017. So it seems they found some other way to deal with it?
- steveklabnik 6y agoAh interesting! Glad they removed it. I can't quite find out when, and I don't have the time to really dig in right now. Very cool, thanks.