4 ms·
> It's not like your passing those variables to functions right there Yes it did. Case blocks had several lines. >So what if they're different types? It make
by akerro 6y ago
> It's not like your passing those variables to functions right there
Yes it did. Case blocks had several lines.
>So what if they're different types?
It makes it hard to read and destroys expectation of what possible cases there are. It makes it hard to test as a lot of test preparation/mocking is necessary.
>Except the recursive function bit. Why bother if its always false...
Yea, that the point! Because there was no test for it
- tomc1985 6y agoWait, so what's the remedy for the different types issue then? Should he coerce all these diverse types into one type just to do the comparison? That just seems wasteful. Assuming he has to do the check that way, of course.
- akerro 6y agoMy solution was to change the checks into single methods and move one god-decision-making-method into classes that are components with their own logic.
- theflyinghorse 6y agoBetter question is "Why are they gating all this crap here like that? What is the presumed set of expected outcomes?". This code is bordering somewhere on the line between sabotage and incompetence and it smells really bad.