2 ms·
> These should absolutely be two independent commits. > I think this opportunity was missed. Uh, they were two independent commits. The test in Chromium was fi
by brucedawson 6y ago
> These should absolutely be two independent commits.
> I think this opportunity was missed.
Uh, they were two independent commits. The test in Chromium was fixed in 2017. The change to googletest landed a few weeks ago in 2020. Separated by three years and in two different repositories - that sounds independent to me.
> This is a false dichotomy. You can fix both!
Yep, did that.
FWIW the failure was originally reported on an x64 test, so the i386 FPU with its 80-bit registers was not used.