4 ms·
I respect the simplicity of Chrome's versioning scheme. 99% of people using SemVer actually only have two types of change: 1. "Updating will probably work, bu
by michaelt 6y ago
I respect the simplicity of Chrome's versioning scheme.
99% of people using SemVer actually only have two types of change:
1. "Updating will probably work, but you should test anyway in case we've introduced a regression or you depend on behaviour we've decided was a bug"
2. "Updating might not work, depending on which features you're using, but you should test anyway and you'll be forced to update eventually anyway"
Given users have to respond in the same way to both, why adopt a versioning system that claims 1.12 is greater than 1.2 ?
- nicoburns 6y agoUsually there's a 3rd type (patch versions): "This update fixes important bugs and will almost certain work if the previous version did"
- arpa 6y agosure it looks weird if you omit the patch part of semver. However, if you think that 2 > 12, perhaps, you're not the target audience for versions in general. /s
- brabel 6y agoI've seen bugs caused by a tool not knowing that version `1.12` < `1.20` :/ so yeah, some professional developers don't know that.
- Joker_vD 6y agoWindows 95 reported it's version as 3.95 instead of 4.00 for this exact reason [0]. Apparently, writing lexicographical ordering on tuples is surprisingly unintuitive: bool operator<=(version lhs, version rhs) { return (lhs.Major <= rhs.Major) || (lhs.Minor <= rhs.Minor) || (lhs.Patch <= rhs.Patch); } looks correct for anyone who have never wrote such comparison before, but of course it's wrong. The correct one is bool operator<=(version lhs, version rhs) { return (lhs.Major < rhs.Major) || ((lhs.Major == rhs.Major) && ((lhs.Minor < rhs.Minor) || ((lhs.Minor == rhs.Minor) && (lhs.Patch <= rhs.Patch)))); } [0] https://devblogs.microsoft.com/oldnewthing/20040213-00/?p=40633 https://devblogs.microsoft.com/oldnewthing/20040213-00/?p=40...
- deleted 6y ago[deleted]
- Lvl999Noob 6y agoYour second code is wrong. For lhs = "4.3.7" and rhs = "3.3.7", your code will give true. It should be false.
- Joker_vD 6y agoUh, no it won't? cat >test_ver.cpp << EOF #include <cstdio> struct version { int Major; int Minor; int Patch; version(int major, int minor, int patch) : Major(major) , Minor(minor) , Patch(patch) { } }; bool operator<=(version lhs, version rhs) { return (lhs.Major < rhs.Major) || ((lhs.Major == rhs.Major) && ((lhs.Minor < rhs.Minor) || ((lhs.Minor == rhs.Minor) && (lhs.Patch <= rhs.Patch)))); } int main(int argc, char **argv) { version lhs(4, 3, 7); version rhs(3, 3, 7); printf("lhs <= rhs? %s\n", lhs <= rhs ? "true" : "false"); } EOF g++ test_ver.cpp -o test_ver && ./test_ver prints lhs <= rhs? false
- tsegers 6y agoNo, it works. It's just non-obvious that it does due to the reliance on 4 levels of braces. It is equivalent to the following: lhs.Major < rhs.Major or (lhs.Major == rhs.Major and lhs.Minor < rhs.Minor) or (lhs.Major == rhs.Major and lhs.Minor == rhs.Minor and lhs.Patch <= rhs.Patch) Deduplicating (lhs.Major == rhs.Major) decreased readability enough to be confusing.
- SAI_Peregrinus 6y ago1v12 is greater than 1v2. The issue is the "." looks like a radix point, so people think they're decimal numbers. Pick some other separator and that confusion goes away (don't use ",", since that's a radix point for many languages).