3 ms·
The opposite. The lack of abstractions, mere industrial copy pasta code is the problem.
by rurban 6y ago
The opposite. The lack of abstractions, mere industrial copy pasta code is the problem.
- andy_ppp 6y agoI’m not saying it’s true here but duplication over the wrong abstraction is always better. Seems to me if each graphics card is different enough there’s probably lots to duplicate.
- VBprogrammer 6y agoIn software development absolutes are always dangerous.
- andy_ppp 6y agoApart from absolutes about absolutes.
- rurban 6y agoNonsense. This duplication is not maintainable and needs massive amounts of memory. Proper abstraction adds a few if else in the data, and is about 20x smaller. You can even read and understand that, e.g. what changed with this HW upgrade. No chance with duplicated blobs of structs and enums.
- andy_ppp 6y ago> I’m not saying it’s true Yes, I did caveat my suggestion. Why not submit a fix if it's so simple ;-)
- mrweasel 6y agoIf the Radeon driver is in the kernel now, then maybe at some point someone other than AMD will pick it up and start cleaning up excessive copy paste code. Assuming they play nice with the community, it could be a huge benefit to AMD in the long run. Still, 2 million lines is a massive amount of code to start working on.
- samus 6y agoUnlikely, unless that entity has all the supported hardware at hand and ready for automated tests. Refactoring without a thorough test harness is ref*toring.