3 ms·
Why did your group want to do a refacctor like that retrospectively rather than just checking in those changes on a forward going basis?
by gumby 6y ago
Why did your group want to do a refacctor like that retrospectively rather than just checking in those changes on a forward going basis?
- acemarke 6y agoHeh. It wasn't even the rest of my team - I'm the only one who cared enough to do anything about it :) Per the post, I wanted to auto-reformat the entire codebase, as well as codemod the JS source to update it to more modern syntax (ES modules instead of AMD, `const/let` instead of `var`, shorthand object literals, etc). But, that would have left most of the codebase history showing that the last commit touching a line was "MARK REFORMATTED ALL THE THINGS". Since I was rewriting the entire repo history to strip out all the junk files that were consuming space, which was going to create an entirely new alternate history anyway, I figured I might as well take advantage of the opportunity to redo all the source as well: https://blog.isquaredsoftware.com/2018/11/git-js-history-rewriting/#the-plan-grows https://blog.isquaredsoftware.com/2018/11/git-js-history-rew...
- gumby 6y ago> But, that would have left most of the codebase history showing that the last commit touching a line was "MARK REFORMATTED ALL THE THINGS". Indeed, this is a good reason to do as you chose. I hadn't thought of it (even though I have done the same to a code base).