3 ms·
Unsolicited advice, please feel free to ignore; hopefully you'll be okay with it: Bug fixes tend to not need justification (since the maintainers presumably al
by mook 6y ago
Unsolicited advice, please feel free to ignore; hopefully you'll be okay with it:
Bug fixes tend to not need justification (since the maintainers presumably already agreed), but new features depend on the maintainers agreeing that they want it in the project. Before making the PR, try to find the relevant issue (or create one if it doesn't already exist), and get the maintainer to indicate that they want the feature. Once they've written that down, they're primed to accept it because they'd feel worse about not processing the thing they already committed to.