2 ms·
I don’t get what the big deal of this is. 1-50 PRs with insignificant changes. Simple fix, simple scripting of prs.all().forEach( if pr.MinorChanges,
by sam1r 6y ago
I don’t get what the big deal of this is. 1-50 PRs with insignificant changes.
Simple fix, simple scripting of
prs.all().forEach(
if pr.MinorChanges,
then close w/ comment).
Minor changes are just taking the number of diff files, and checking if it’s less than > 1. That’s just one way to do it.
Feels like enough venting has been done, but why bring up the problem when you can come forth with a solution. Or at least propose one?
Furthermore, does this deserve Twitter attention? How about ours? [hn commubity]
- xmprt 6y agoA lot of minor changes are important though and blanket closing all diffs with minor changes will take out legitimate changes with it. Also, it's so easy to get around this by just making diffs with two files changed. Or making a diff that copy pastes the same line 100 times.