3 ms·
Using "new" is code smell. This is easily caught in code review.
by UncleMeat 6y ago
Using "new" is code smell. This is easily caught in code review.
- pjmlp 6y agoLike those that Google does for Android?
- CyberDildonics 6y agoRaw pointers for ownership are a bad idea, one of google's 30,000 programmers doing it doesn't change that. You are the only one pointing to google as an authority.
- pjmlp 6y agoI am the only one, because the others don't care to point anything.
- CyberDildonics 6y agoOther people are pointing to the actual fundamental reasons these things exist and are valuable, you are pointing to a bizarre false authority as a desperate rationalization for not liking C++.
- UncleMeat 6y agoYou are really harping on this one example. I don't know what processes Google uses for the Android codebase, but in the main code base make_shared has only been available for a little while. Today, "new" is smell that should be caught in code review at Google. When was this committed?
- pjmlp 6y agoYes, because Google is a major contributor to ISO C++, LLVM, clang, has billions of C++ code, and yet fails to follow best practices. So what to be expected by those companies that hardly have such a deep knowledge about C++ among their troops?
- pkolaczk 6y agoGoogle is a huge company and the majority of its employees are not contributors to ISO C++.