3 ms·
Some people only review the final diff and don't go through the code commit by commit.
by pawelmor 6y ago
Some people only review the final diff and don't go through the code commit by commit.
- mytailorisrich 6y agoThere should be only a single commit, vetted by the code review. What happens before on a private branch (usually on a local copy of the repo) can be purged (and probably should be purged as a matter of course) if there is a worry of what might be contained in there. The bottom line for is that the most important is to define a good process first before trying to use tooling to correct process deficiencies. A good process brings many benefits by 'forcing' good outcomes and avoid a lot of headaches.
- pawelmor 6y agoI completely agree that this is how the review should be done. But this is not the case in all companies.
- mytailorisrich 6y ago> But this is not the case in all companies. In that case it's worth fixing the process before adding layers of tooling.
- oodelally 6y agoNot the current state of the world!
- deleted 6y ago[deleted]