Seems you already have the basic pros and cons. To add here, I have seen a colleague who decided to break the news in advance because of good personal and worki

Seems you already have the basic pros and cons. To add here, I have seen a colleague who decided to break the news in advance because of good personal and working relations with the employer, and offer to help in the meantime.