4 ms·
Still sitting at 725 unmerged and/or unrejected PRs though.
by theon144 6y ago
Still sitting at 725 unmerged and/or unrejected PRs though.
- ekianjo 6y agoIs there anything bad about that number? Something which is very popular is bound to get a lot of PRs, and reviewing them takes time.
- kzrdude 6y agoThe job of a maintainer is to reject PRs. So yeah, they are falling behind in saying no, maybe they just don't want to say no, so they let them sit. Happens everywhere.
- xorcist 6y agoLet's hope the fork merges those 700 PRs and see which project is maintained in five years. Keeping software well maintained involves a lot of saying no, unfortunately.
- chrisseaton 6y ago> Keeping software well maintained involves a lot of saying no, unfortunately. Right... and the youtube-dl maintainers aren't doing that.
- slenk 6y agoWouldn't not merging a PR be the same as saying no
- chrisseaton 6y agoSaying 'no thanks' and closing is saying 'no'. Leaving it unacknowledged isn't saying yes or no.
- slenk 6y agoGood point.
- joshvm 6y agoWorth mentioning that youtubedl works with a lot of sites, not just YouTube. Most of those PRs are for other supported websites or requesting support for new sites.