3 ms·
I hate to judge a project by the technology choices but no SSL on the landing page and PHP is just the tip of the iceberg here. - Every table uses MyISAM. Int
by frompdx 6y ago
I hate to judge a project by the technology choices but no SSL on the landing page and PHP is just the tip of the iceberg here.
- Every table uses MyISAM. Interesting choice, but maybe the fancy features of InnoDB aren't really needed.
- HTML in the database for storing page templates. The entire workflow in terms of HTML views of the application process are stored in the database. That's got to be rough to maintain. https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca93874d02c7288728df0f87/db/cats_schema.sql#L432 https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca...
- Uses mcrypt (not for passwords), which is deprecated and also abandonware. https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca93874d02c7288728df0f87/lib/Encryption.php#L43 https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca...
- Passwords appear to be stored as md5 hashes. https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca93874d02c7288728df0f87/lib/Users.php#L840 https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca...
- Yep, md5. https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca93874d02c7288728df0f87/lib/Users.php#L93 https://github.com/opencats/OpenCATS/blob/77c1f2bcf1bc92f4ca...
- randtrain34 6y agoand fun XSS vulns https://github.com/opencats/OpenCATS/issues/406 https://github.com/opencats/OpenCATS/issues/406