4 ms·
There's really no reason to believe in the provenance of any of the code in the Linux kernel. People mail around patchsets, claim they are "signed off by" someo
by jeffbee 6y ago
There's really no reason to believe in the provenance of any of the code in the Linux kernel. People mail around patchsets, claim they are "signed off by" someone, and they get patched into various trees and merged here and there, and eventually wind up in Linus's tree. It has all of the safety of email, which is to say none at all. Compared to code review practices at software companies, where diffs are reviewed and approved by identities authenticated and authorized by secure computer systems, the linux kernel system is a complete joke.
- saagarjha 6y agoOh, come on, the code review process at most companies is fairly easy to bypass. Even at the company I'm sure you're going to bring up I would seriously doubt it wouldn't be possible to slip something into a long patch, even though I'm sure there are some sort of guidelines on who and how many people should be reviewing things.
- deleted 6y ago[deleted]
- maccard 6y agoIve said this before on here, but I'm 95% sure I could find two or three on my team and say "hey I have a simple fix for X, needs to go in quick, can I tag you in it?", and they would rubber stamp it knowing it comes from me.
- chromedev 6y agoPatches are reviewed just not in the way you are accustomed to, but it doesn't make it any less secure. The kernel is continually audited and tested, and is the most widely used kernel in security devices. What you are asking for is that developers should have to prove their real-life identity and authenticate to a public SCM system and that somehow makes it more secure, when hidden exploits could as easily be sent as a PR on GitHub and merged by someone who didn't know better or who can just play dumb.
- jeffbee 6y agoI don't buy "continually audited and tested". That is a variant of the "many eyes make all bugs shallow" theory or "Linus's Law", but that hasn't proven to be the case. The Linux kernel is full of bugs and many of them hang around for years. Also the kernel testing story is a total joke. Perhaps you meant that people use the kernel and therefore it's "tested"?
- jnurmine 6y agoCalling Linux testing a "total joke" is a total joke in itself -- of course Linux is not perfect (nothing is). As for testing, there is kernelci.org, LTP, Syzbot, LKFT and so on. It's not just a bunch people in basements booting up the latest Linux and calling it testing.
- jeffbee 6y agoThe fact that syzkaller finds a new bug every 10 seconds is an indictment of Linux testing, not evidence of its quality.
- edoceo 6y agoI couldn't find anything at every 10 seconds (wouldnt that be 8k issues per day?) This reporting list has a few per day https://groups.google.com/forum/m/#!forum/syzkaller-bugs https://groups.google.com/forum/m/#!forum/syzkaller-bugs Isn't testing supposed to find bugs? And aren't fuzzers identifying issues that /might/ exist in theory but dont manifest in practice? From your assessment I'm surprised my Linux boxen don't crash every day and really surprised I had one stay online for five years - but, many things things about Linux surprise me.
- jeffbee 6y agoTesting is supposed to prevent bugs from being committed. Finding the bugs in released software after the fact is the worst possible process. The fact is that people discover and fix bugs, and then years later someone else commits the same mistake again, and nothing prevents this because the kernel has literally zero pre-commit unit tests. Here's an example (thread by the author of syzkaller). https://twitter.com/dvyukov/status/1169544165023240194 https://twitter.com/dvyukov/status/1169544165023240194
- deleted 6y ago[deleted]
- bonzini 6y agoWhen commits move from one tree to another (which is the only time when full code review isn't done, because the maintainer is generally trusted), it is done with a GPG-signed tag. Email's lack of signing therefore is not an issue.
- SahAssar 6y agoYou just proved you have no idea what you're talking about.