4 ms·

> What are we doing wrong? Let me answer your question with your own quote: > The thing is, everyone I speak to in the project hates it and not just because i

> What are we doing wrong? Let me answer your question with your own quote: > The thing is, everyone I speak to in the project hates it and not just because it’s new and they don’t like change. Tech industry is all about change, and since there is so much change, we have to rely a lot of having good processes that can be applied to all sorts of changes. It does sound like your company dropped a bomb of a bunch of changes - they probably could have baby-stepped into code review before also switching to git. Too much change is hard for anyone. But I don't think your company's problem is git. I used to be the guy that had a single branch project with pushes directly to master, live changes on production, some days had multiple deploys as we discovered bugs. While that was _easy_ from the perspective of "hey, I could just push code, and it was great", it was hard because all deploys were high-stakes, and could mean spending hours debugging and redeploying into the after hours of my work day (and this happened regularly). Just to ask a question back to you, how many times did your company's simple SVN process backfire and cause more work for you?

JacKTrocinskI 6y ago
I am unaware of SVN backfiring, however I do see peer reviews as being grossly overlooked in the project. However, Git does not solve that problem because people just click the approve button in Odyssey without actually reviewing the code.
- kazinator 6y ago
  Just like traffic lights and road signs don't prevent accidents because some drivers ignore them. Surely Odyssey keeps a record of who approved what. If you approve something, your name should be attached as having reviewed. Then you share some of the responsibility if the commit is bad.
- mrozbarry 6y ago
  Oh, to be clear, I'm not saying that SVN itself backfired, but the process they used, which sounded a lot like firing from the hip for new features.

JacKTrocinskI 6y ago

I am unaware of SVN backfiring, however I do see peer reviews as being grossly overlooked in the project. However, Git does not solve that problem because people just click the approve button in Odyssey without actually reviewing the code.

kazinator 6y ago
Just like traffic lights and road signs don't prevent accidents because some drivers ignore them. Surely Odyssey keeps a record of who approved what. If you approve something, your name should be attached as having reviewed. Then you share some of the responsibility if the commit is bad.
mrozbarry 6y ago
Oh, to be clear, I'm not saying that SVN itself backfired, but the process they used, which sounded a lot like firing from the hip for new features.