6 ms·

I don't understand how those follow. Note that your "initial setup" follows you from project to project and even machine to machine if you sync your config file

I don't understand how those follow. Note that your "initial setup" follows you from project to project and even machine to machine if you sync your config files.

corobo 6y ago
Ok that's fair and I overlooked a lot of it being a global config setup. It still stands though that you can cut out an entire page and a half of your instructions with "step 4: git push origin main" for each repo This isn't even taking into account getting other devs working with it, contractors we're working with, outside agencies that may be involved in this one How do you even get the patch into the repo from an email? I couldn't see that instruction but may have overlooked that too
- ddevault 6y ago
  Watch the video I linked to, please. You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. And that's only if you already have a GitHub account. If you don't, add answering the registraiton email and adding your SSH key to those steps. In your situation, having a single shared git repo might make sense, sure. But we're not talking about that, we're talking about code review strategies.
  - nonbirithm 6y ago
    > You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. Not if you're using GitHub, because they have APIs for that: hub fork --remote-name origin git push origin feature hub ci-status --verbose hub pull-request https://hub.github.com/ https://hub.github.com/
    - ddevault 6y ago
      Install and learn how to use more third-party software to use a propreitary API on a centralized, proprietary, unreliable service... or just use the built-in git tooling?
      - rfoo 6y ago
        Where is the builtin git tooling for showing side by side diff with proper syntax and different parts highlighting, and make it possible to turn my review comments back to the "bottom-posting" style text emails interleaved with the inline diff everyone on the mailing list strongly insisting? I'm sorry but I'm a stupid noob and my eye is not able to parse codes without syntax highlighting.
        ddevault 6y ago
        It's called your email client.
  - corobo 6y ago
    When I git push main it's instantly available and deployed to the live server(s) - but you're right I wouldn't push direct to main, I'd click the link that the push process output (Self hosted GitLab for context) and create a merge request I've got a feeling I'll never properly see your point of view on this, as these tools exist and I'm not planning on dropping them for an unfriendly email version of the same, but I will give the video a proper as open minded as I can watch after work
    - ddevault 6y ago
      I reckon you've never tried the email based tools. Ditch the assumption that they're unfriendly until you're knowledgable about it.
      - corobo 6y ago
        I felt your video was dishonest right from the start. If your password manager doesn’t easily meet those password requirements with default settings you need a new one. Also who is registering a new account each time? I’m sure you recognise this argument :) “I’ve got greylisting enabled on my server” which would affect your git email flow, but you don’t mention that. [edit: oooh, what about spam filtering? How many requests are lost to that?] The slow back button presses as if it takes that long lmao. You’re proper at it. Shocker you’re typing nice and smoothly in the email flow. Didn’t see that coming. No mention of getting changes into the repo after receiving the email patch. Where’s your merge request equivalent? That step must be so easy and so much faster than using a web interface you just forgot to record it. Context switching is moving a mouse to the other screen.. come on, just be real with me! I’m trying to learn your thing - just stick to it. Focus.. I’m sorry but this video contains too much bullshit and not enough info. I want to learn, not accept FUD. Hit me up with a clean version if you make one. May I suggest a side by side video edit? At best they seem evenly matched. In which case I choose the path of inaction You’ve gone from interesting tech person to PR spinner in my mind. Quite disappointing.
  - rfoo 6y ago
    > And that's only if you already have a GitHub account. Come on, I get that you hate being locked in a proprietary service which requires an "account", but if you want to make this point then I'm sure people could say "And that's only if you already have an email" and your tutorial should include setting up your own mail server.
    - ddevault 6y ago
      Come on, I know that you hate the idea of facing your cognative dissonance, but there are different things. When was the last time you met someone who didn't have an email account? And you can set up an email address on any of dozens of email providers, and use them to communicate with any of the rest. I can't sign up on GitLab and use that account to post on GitHub.

I don't understand how those follow. Note that your "initial setup" follows you from project to project and even machine to machine if you sync your config files.

corobo 6y ago

Ok that's fair and I overlooked a lot of it being a global config setup. It still stands though that you can cut out an entire page and a half of your instructions with "step 4: git push origin main" for each repo This isn't even taking into account getting other devs working with it, contractors we're working with, outside agencies that may be involved in this one How do you even get the patch into the repo from an email? I couldn't see that instruction but may have overlooked that too

ddevault 6y ago
Watch the video I linked to, please. You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. And that's only if you already have a GitHub account. If you don't, add answering the registraiton email and adding your SSH key to those steps. In your situation, having a single shared git repo might make sense, sure. But we're not talking about that, we're talking about code review strategies.
- nonbirithm 6y ago
  > You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. Not if you're using GitHub, because they have APIs for that: hub fork --remote-name origin git push origin feature hub ci-status --verbose hub pull-request https://hub.github.com/ https://hub.github.com/
  - ddevault 6y ago
    Install and learn how to use more third-party software to use a propreitary API on a centralized, proprietary, unreliable service... or just use the built-in git tooling?
    - rfoo 6y ago
      Where is the builtin git tooling for showing side by side diff with proper syntax and different parts highlighting, and make it possible to turn my review comments back to the "bottom-posting" style text emails interleaved with the inline diff everyone on the mailing list strongly insisting? I'm sorry but I'm a stupid noob and my eye is not able to parse codes without syntax highlighting.
      - ddevault 6y ago
        It's called your email client.
- corobo 6y ago
  When I git push main it's instantly available and deployed to the live server(s) - but you're right I wouldn't push direct to main, I'd click the link that the push process output (Self hosted GitLab for context) and create a merge request I've got a feeling I'll never properly see your point of view on this, as these tools exist and I'm not planning on dropping them for an unfriendly email version of the same, but I will give the video a proper as open minded as I can watch after work
  - ddevault 6y ago
    I reckon you've never tried the email based tools. Ditch the assumption that they're unfriendly until you're knowledgable about it.
    - corobo 6y ago
      I felt your video was dishonest right from the start. If your password manager doesn’t easily meet those password requirements with default settings you need a new one. Also who is registering a new account each time? I’m sure you recognise this argument :) “I’ve got greylisting enabled on my server” which would affect your git email flow, but you don’t mention that. [edit: oooh, what about spam filtering? How many requests are lost to that?] The slow back button presses as if it takes that long lmao. You’re proper at it. Shocker you’re typing nice and smoothly in the email flow. Didn’t see that coming. No mention of getting changes into the repo after receiving the email patch. Where’s your merge request equivalent? That step must be so easy and so much faster than using a web interface you just forgot to record it. Context switching is moving a mouse to the other screen.. come on, just be real with me! I’m trying to learn your thing - just stick to it. Focus.. I’m sorry but this video contains too much bullshit and not enough info. I want to learn, not accept FUD. Hit me up with a clean version if you make one. May I suggest a side by side video edit? At best they seem evenly matched. In which case I choose the path of inaction You’ve gone from interesting tech person to PR spinner in my mind. Quite disappointing.
- rfoo 6y ago
  > And that's only if you already have a GitHub account. Come on, I get that you hate being locked in a proprietary service which requires an "account", but if you want to make this point then I'm sure people could say "And that's only if you already have an email" and your tutorial should include setting up your own mail server.
  - ddevault 6y ago
    Come on, I know that you hate the idea of facing your cognative dissonance, but there are different things. When was the last time you met someone who didn't have an email account? And you can set up an email address on any of dozens of email providers, and use them to communicate with any of the rest. I can't sign up on GitLab and use that account to post on GitHub.