4 ms·

This isn't a great take. I recorded a demonstration which shows the differences between the workflows more clearly: https://spacepub.space/videos/watch/1619c00

This isn't a great take. I recorded a demonstration which shows the differences between the workflows more clearly: https://spacepub.space/videos/watch/1619c000-7c44-4330-9177-29a0854bd759 https://spacepub.space/videos/watch/1619c000-7c44-4330-9177-... After the initial setup, send-email is way faster.

corobo 6y ago
I work at a web agency. Initial setup is frequent
- ddevault 6y ago
  I don't understand how those follow. Note that your "initial setup" follows you from project to project and even machine to machine if you sync your config files.
  - corobo 6y ago
    Ok that's fair and I overlooked a lot of it being a global config setup. It still stands though that you can cut out an entire page and a half of your instructions with "step 4: git push origin main" for each repo This isn't even taking into account getting other devs working with it, contractors we're working with, outside agencies that may be involved in this one How do you even get the patch into the repo from an email? I couldn't see that instruction but may have overlooked that too
    - ddevault 6y ago
      Watch the video I linked to, please. You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. And that's only if you already have a GitHub account. If you don't, add answering the registraiton email and adding your SSH key to those steps. In your situation, having a single shared git repo might make sense, sure. But we're not talking about that, we're talking about code review strategies.
      - nonbirithm 6y ago
        > You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. Not if you're using GitHub, because they have APIs for that: hub fork --remote-name origin git push origin feature hub ci-status --verbose hub pull-request https://hub.github.com/ https://hub.github.com/
        ddevault 6y ago
        Install and learn how to use more third-party software to use a propreitary API on a centralized, proprietary, unreliable service... or just use the built-in git tooling?
        rfoo 6y ago
        Where is the builtin git tooling for showing side by side diff with proper syntax and different parts highlighting, and make it possible to turn my review comments back to the "bottom-posting" style text emails interleaved with the inline diff everyone on the mailing list strongly insisting? I'm sorry but I'm a stupid noob and my eye is not able to parse codes without syntax highlighting.
        ddevault 6y ago
        It's called your email client.
      - corobo 6y ago
        When I git push main it's instantly available and deployed to the live server(s) - but you're right I wouldn't push direct to main, I'd click the link that the push process output (Self hosted GitLab for context) and create a merge request I've got a feeling I'll never properly see your point of view on this, as these tools exist and I'm not planning on dropping them for an unfriendly email version of the same, but I will give the video a proper as open minded as I can watch after work

corobo 6y ago

I work at a web agency. Initial setup is frequent

ddevault 6y ago
I don't understand how those follow. Note that your "initial setup" follows you from project to project and even machine to machine if you sync your config files.
- corobo 6y ago
  Ok that's fair and I overlooked a lot of it being a global config setup. It still stands though that you can cut out an entire page and a half of your instructions with "step 4: git push origin main" for each repo This isn't even taking into account getting other devs working with it, contractors we're working with, outside agencies that may be involved in this one How do you even get the patch into the repo from an email? I couldn't see that instruction but may have overlooked that too
  - ddevault 6y ago
    Watch the video I linked to, please. You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. And that's only if you already have a GitHub account. If you don't, add answering the registraiton email and adding your SSH key to those steps. In your situation, having a single shared git repo might make sense, sure. But we're not talking about that, we're talking about code review strategies.
    - nonbirithm 6y ago
      > You can't just `git push origin main` - you have to do that, then go to the web browser, create a fork, and open a pull request. Not if you're using GitHub, because they have APIs for that: hub fork --remote-name origin git push origin feature hub ci-status --verbose hub pull-request https://hub.github.com/ https://hub.github.com/
      - ddevault 6y ago
        Install and learn how to use more third-party software to use a propreitary API on a centralized, proprietary, unreliable service... or just use the built-in git tooling?
        rfoo 6y ago
        Where is the builtin git tooling for showing side by side diff with proper syntax and different parts highlighting, and make it possible to turn my review comments back to the "bottom-posting" style text emails interleaved with the inline diff everyone on the mailing list strongly insisting? I'm sorry but I'm a stupid noob and my eye is not able to parse codes without syntax highlighting.
        ddevault 6y ago
        It's called your email client.
    - corobo 6y ago
      When I git push main it's instantly available and deployed to the live server(s) - but you're right I wouldn't push direct to main, I'd click the link that the push process output (Self hosted GitLab for context) and create a merge request I've got a feeling I'll never properly see your point of view on this, as these tools exist and I'm not planning on dropping them for an unfriendly email version of the same, but I will give the video a proper as open minded as I can watch after work