5 ms·
I absolutely adore that this link isn't clickable, yet it works when you copy-paste it into Chrome. @dang, here's an updated version of valid-url which will ma
by sillysaurusx 6y ago
I absolutely adore that this link isn't clickable, yet it works when you copy-paste it into Chrome.
@dang, here's an updated version of valid-url which will make the link clickable:
(defmemo valid-url (url)
(and (len> url 10)
(or (begins url "http://")
(begins url "https://")
(begins url "ftp://"))
(~find [in _ #\< #\> #\" #\'] url)))
I doubt it'll get merged, but you never know.
It looks like the other change necessary is in the `markdown` function. It checks:
(and (or (litmatch "http://" s i)
(litmatch "https://" s i)
You'd need to add:
(litmatch "ftp://" s i)
If you grep the codebase for "https" then it'll reveal any other functions that need updates, but these are the only two in arc3.1.
Of course, the cost-benefit doesn't quite add up here – it's not like ftp links are too common. But think of the poor university FTP servers! They'll be forever doomed to copy-paste-hell unless this is fixed. :-(
- the_pwner224 6y agoFirefox removed FTP support some months ago. Ironically when I copy paste that link it now prompts me to open it in Chromium.
- garmaine 6y agoWTF? that is ridiculous. I might drop Firefox over this. That might sound crazy (FTP is an ancient protocol), but I spend a lot of time scouring FTP servers for old technical reports. Mozilla can't just wish FTP away.
- pritambaral 6y agoDoes your OS's builtin file manager not support this?
- read_if_gay_ 6y agoI mean, if you didn’t notice for a few months, is it really that big of a deal?
- garmaine 6y agoIt’s not live yet on whatever release branch I’m currently running.
- pjmlp 6y agoOne user more for ChromeOS.
- garmaine 6y agoI will never use Chrome.
- Doingmything123 6y agoWorks on Firefox 80
- Santosh83 6y agoDitto. Works as is on Firefox 80. No need to edit the URL. It is however not clickable, but you can select it and click "open in new tab" and it opens the PDF just fine.
- jhoechtl 6y agoWorks for FF 79, Manjaro Linux Maybe it was removed for the Windows build? If so, what a bad decision, maybe for security reasons?
- the_pwner224 6y agohttps://blog.mozilla.org/addons/2020/04/13/what-to-expect-for-the-upcoming-deprecation-of-ftp-in-firefox/ https://blog.mozilla.org/addons/2020/04/13/what-to-expect-fo... I normally use FF Nightly which explains the difference.
- konjin 6y agoThat assumes that your browser supports ftp, which isn't the case in Firefox. If you're going to support ftp you might as well support generic URIs. URI := scheme:[//authority]path[?query][#fragment] Not sure what arcs support for regular languages is like.
- dependenttypes 6y ago> which isn't the case in Firefox It certainly is, at least on Firefox 80.