3 ms·

How on earth does React encourage the bad practice of “hovers in JS”? React absolutely has zero influence on this - that one is entirely on the developers. I’m

How on earth does React encourage the bad practice of “hovers in JS”? React absolutely has zero influence on this - that one is entirely on the developers. I’m also exceptionally confused why the Pagespeed score was sitting at just 5/100 - it doesn’t sound like the dev team actually understood the result and attempted to resolve it. It sounds like the author has found some new technology they’re happy with for now, but it sounds like all the previous problem were self inflicted and they’re bound to repeat them again. While different tech and frameworks has an influence in the problems you’ll face, you’ve still got to do good programming.

schwartzworld 6y ago
If you are writing JS styles, you don't have access to pseudoselectors like :hover. A quick solution adopted by many is simulating hover with onMouseEnter and onMouseLeave event handlers. This can be remedied by using CSS or styled-components.
- madeofpalk 6y ago
  This is nowhere near a common practice (I've never seen it on any work project, or on community projects). React does not promote or advocate or make it easier to do it this way, rather than the proper way in CSS.
  - schwartzworld 6y ago
    It is actually in the react documentation. https://reactjs.org/docs/dom-elements.html#style https://reactjs.org/docs/dom-elements.html#style I'm not saying that's how it should be done. I'm just clarifying what the author of the article was referring to.
    - madeofpalk 6y ago
      Correct, it is documented. That's what documentation is - to list out and describe the API surface. The entire documentation block for that is prefixed with a big yellow-box warning: > using the style attribute as the primary means of styling elements is generally not recommended. And then it links to https://reactjs.org/docs/faq-styling.html https://reactjs.org/docs/faq-styling.html which just says over and over again "use class names"
      - schwartzworld 6y ago
        So just to be clear A) it didn't always have that warning and B) I wasn't defending the practice. Did you read the article?

schwartzworld 6y ago

If you are writing JS styles, you don't have access to pseudoselectors like :hover. A quick solution adopted by many is simulating hover with onMouseEnter and onMouseLeave event handlers. This can be remedied by using CSS or styled-components.

madeofpalk 6y ago
This is nowhere near a common practice (I've never seen it on any work project, or on community projects). React does not promote or advocate or make it easier to do it this way, rather than the proper way in CSS.
- schwartzworld 6y ago
  It is actually in the react documentation. https://reactjs.org/docs/dom-elements.html#style https://reactjs.org/docs/dom-elements.html#style I'm not saying that's how it should be done. I'm just clarifying what the author of the article was referring to.
  - madeofpalk 6y ago
    Correct, it is documented. That's what documentation is - to list out and describe the API surface. The entire documentation block for that is prefixed with a big yellow-box warning: > using the style attribute as the primary means of styling elements is generally not recommended. And then it links to https://reactjs.org/docs/faq-styling.html https://reactjs.org/docs/faq-styling.html which just says over and over again "use class names"
    - schwartzworld 6y ago
      So just to be clear A) it didn't always have that warning and B) I wasn't defending the practice. Did you read the article?