3 ms·

I think their (the kernel maintainers’) position is that a single patch of 27000 lines of diffs is a bit of a nightmare to do code review on. I’m not sure if yo

by Pick-A-Hill2019 6y ago

I think their (the kernel maintainers’) position is that a single patch of 27000 lines of diffs is a bit of a nightmare to do code review on. I’m not sure if you took a look at the patch file (available at https://dl.paragon-software.com/ntfs3/ntfs3.patch https://dl.paragon-software.com/ntfs3/ntfs3.patch ). I think their point is ‘man, how are we going to divide this up amongst the maintainers? Who gets to check which function or call?’ Paragons response (more or less will fix in v2) https://lore.kernel.org/linux-fsdevel/a8fa5b2b31b349f2858306af01269eda@paragon-software.com/ https://lore.kernel.org/linux-fsdevel/a8fa5b2b31b349f2858306...

tyingq 6y ago
Using language like "monstrosity" though, doesn't help.
- znpy 6y ago
  I guess that's not you that have to do the review.
  - tyingq 6y ago
    Heh. I've certainly been handed stuff I didn't like. It's always been easier to work through if I avoided anything that came off as emotional or insulting.
- boomboomsubban 6y ago
  The word has several meanings, and I took it to mean "frighteningly large" rather than any of the more negative ones. Perhaps not the best choice, but not overtly rude.
- hodgesrm 6y ago
  "Monstrosity" seems like a fair word, and to the point as well. The follow-up messages showed good will on the part of the kernel maintainers.
- sorryd4d 6y ago
  Sorry, dad. We’ll all try really hard to ignore our individual biology to satisfy the most sensitive sensibilities. Cause that expectation is not manipulative at all.
  - dang 6y ago
    Could you please stop posting flamebait and unsubstantive comments to HN? Also, could you please stop creating accounts for every few comments you post? We ban accounts that do that. This is in the site guidelines: https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html. You needn't use your real name, of course, but for HN to be a community, users need some identity for other users to relate to. Otherwise we may as well have no usernames and no community, and that would be a different kind of forum. https://hn.algolia.com/?sort=byDate&dateRange=all&type=comment&storyText=false&prefix&page=0&query=community%20identity%20by:dang https://hn.algolia.com/?sort=byDate&dateRange=all&type=comme...
dboreham 6y ago
If it's working code (assume it is) then requiring it to be turd-polished for the purposes of code review is absurd. Whoever is asking for that is either disingenuous or has no real experience as a software developer.
- hanselot 6y ago
  You would merge 27k of "working" code into one of your main projects based entirely on good faith? Now lets ask rather, would you merge 27k of "working" code into something that runs 90% of the planet?

tyingq 6y ago

Using language like "monstrosity" though, doesn't help.

znpy 6y ago
I guess that's not you that have to do the review.
- tyingq 6y ago
  Heh. I've certainly been handed stuff I didn't like. It's always been easier to work through if I avoided anything that came off as emotional or insulting.
boomboomsubban 6y ago
The word has several meanings, and I took it to mean "frighteningly large" rather than any of the more negative ones. Perhaps not the best choice, but not overtly rude.
hodgesrm 6y ago
"Monstrosity" seems like a fair word, and to the point as well. The follow-up messages showed good will on the part of the kernel maintainers.
sorryd4d 6y ago
Sorry, dad. We’ll all try really hard to ignore our individual biology to satisfy the most sensitive sensibilities. Cause that expectation is not manipulative at all.
- dang 6y ago
  Could you please stop posting flamebait and unsubstantive comments to HN? Also, could you please stop creating accounts for every few comments you post? We ban accounts that do that. This is in the site guidelines: https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html. You needn't use your real name, of course, but for HN to be a community, users need some identity for other users to relate to. Otherwise we may as well have no usernames and no community, and that would be a different kind of forum. https://hn.algolia.com/?sort=byDate&dateRange=all&type=comment&storyText=false&prefix&page=0&query=community%20identity%20by:dang https://hn.algolia.com/?sort=byDate&dateRange=all&type=comme...

dboreham 6y ago

If it's working code (assume it is) then requiring it to be turd-polished for the purposes of code review is absurd. Whoever is asking for that is either disingenuous or has no real experience as a software developer.

hanselot 6y ago
You would merge 27k of "working" code into one of your main projects based entirely on good faith? Now lets ask rather, would you merge 27k of "working" code into something that runs 90% of the planet?