4 ms·
Everyone's chiming in with "you should always use 'this' because it's more explicit", which I personally tend to agree with. But there is a dimension to this th
by brundolf 6y ago
Everyone's chiming in with "you should always use 'this' because it's more explicit", which I personally tend to agree with. But there is a dimension to this that may not be obvious to people who don't come from Java/C#: these languages don't have non-member functions or variables. So if you're accessing a variable without [obj]. it's either a member of the current object, or it's a local variable in the current function. If you call a function without [obj]. it's unlikely (maybe impossible? I'm not certain) that it isn't a method of the current object. On top of that, by idiom Java and C# code tends to be dramatically more verbose than many other languages. So I could understand the desire to cut that down some when there would also be less ambiguity than in, say, JavaScript.
Edit: @masklinn pointed out the static imports feature, which allows you to import static methods in a such a way that they don't have to be prefixed with the class name when calling them, so I take back what I said about function calls
- masklinn 6y ago> these languages don't have non-member functions or variables Not true. Both have static imports. Which means in e.g. PI * Pow(Radius, 2); all three symbols may or may not be part of the current class. In this case, only Radius is, the other two come from `using static System.Math` (it's straight from an official example for the `using static` directive). Also > it's either a member of the current object, or it's a local variable in the current function. So they do have non-member variables, in local variables. Making it clear that something is not a local variable is valuable as it means the variable has a much larger scope than you might expect.
- brundolf 6y agoI didn't know about static imports. Technically those are still member functions, but you are able to call them without a prefix, so I retract that point. > So they do have non-member variables, in local variables. Making it clear that something is not a local variable is valuable as it means the variable has a much larger scope than you might expect. Yes, local variables are non-member variables. I'm just pointing out that people's habits may have been built in JavaScript or the like, where a non-member variable could be: - a global - from a closure, anywhere up the tree - an import from another file Whether or not the explicitness is still important in C# code, it's at least much more important in JavaScript and Python code (in fact I'm pretty sure both languages require it)
- masklinn 6y ago> Yes, local variables are non-member variables. I'm just pointing out that people's habits may have been built in JavaScript or the like, where a non-member variable could be: > - a global > - from a closure, anywhere up the tree > - an import from another file C# has "from a closure, anywhere up the tree" and "an import from an other file" though, the only thing it arguably doesn't have is "a global". > Whether or not the explicitness is still important in C# code, it's at least much more important in JavaScript and Python code (in fact I'm pretty sure both languages require it) Technically you can use the `with` statement to make it implicit in javascript. You should not, but you can.
- deleted 6y ago[deleted]
- Bjartr 6y agoHow common is it for code editing tools to be able to highlight local methods v statically imported ones differently? I know Eclipse does it, but I don't know how prevalent the feature is. e.g. Can Vim do it?
- kords 6y agoNot sure if Vim can do it, but code can be read outside of editors. Sometimes people review PRs in browsers. I can see why there might be a confusion when using static imports or properties/methods from the base class without the base keyword.
- tjalfi 6y ago> So if you're accessing a variable without [obj]. it's either a member of the current object, or it's a local variable in the current function. It could also be a field in the parent class. Protected fields are a bad idea but I’m sure some people use them.
- brundolf 6y agoA field in the parent class is still a member of the current object, and I'm pretty sure there's no way "this." could make a difference there, right?
- tjalfi 6y agoYou're correct that the presence or absence of a "this." shouldn't make a difference. Having said that, C# also permits you to have fields with the same name in both the parent class and the current object. This will give you a compiler warning suggesting you use the new keyword, though.
- deleted 6y ago[deleted]
- bradjohnson 6y agoIn addition to static imports, static fields and functions that belong to the instantiated class are not members of the current object.