5 ms·
I think that this might be an typo or at least it has plausible deniability. I have changed my coding style to always put constant on left side just to avoid su
by stiray 6y ago
I think that this might be an typo or at least it has plausible deniability. I have changed my coding style to always put constant on left side just to avoid such an error (such typo gave me a few days of debugging multithreaded code and I have just said "Never again!!" :D)
- sild 6y agoIf you are using gcc you can use the -Wparentheses flag to turn on warnings for this: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wparentheses https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#inde...
- luckylion 6y agoA typo is possible if it had been submitted to normal code review, but hacking into a server to secretly modify code all but rules out an accident.
- Tuna-Fish 6y agoEven with the "typo" corrected, the patch makes no sense. There is no plausible deniability why it should do what it would do. It was definitely a deliberate attack.