3 ms·
Post-commit review worked quite well when I worked on a product with quarterly release cycle. The master had to stay green (or blue, actually) and all commits
by krab 6y ago
Post-commit review worked quite well when I worked on a product with quarterly release cycle.
The master had to stay green (or blue, actually) and all commits should have been reviewed before release. Each feature had its own short lived branch. Architectural issues and larger refactorings were of course discussed in advance. Because the code wasn't released that often, it didn't matter that much if the review was done in master or in the feature branch and this way minimized conflicts.
I wouldn't recommend it for a system with frequent deployments and more than a handful of developers.