Each to his own. If I found that a junior had created two separate popups, one for add and one for edit, I'd want to look into the code with them to understand

Each to his own. If I found that a junior had created two separate popups, one for add and one for edit, I'd want to look into the code with them to understand if that was a good choice, because usually it wouldn't be for anything with more that one or two properties.