3 ms·
A major accessibility problem with this: the list uses <div>s with click handlers, rather than links. This makes it not respond properly to clicks with modifier
by chrismorgan 6y ago
A major accessibility problem with this: the list uses <div>s with click handlers, rather than links. This makes it not respond properly to clicks with modifiers (e.g. Ctrl+click), not have the right context menu options, not show the href in the status bar, and be completely unusable to users of tools like screen readers or those that would navigate by keyboard.
Never ever do this. If it opens a new page, it’s a link. <div> with a click handler is the wrong thing >99.99% of the time: it should be a link or a button.
- syx 6y agohi I'm the creator of the page, thank you for the suggestion and for the explanation
- linkmotif 6y agoAccessibility is super important, but gosh your comment here is downright horrible. It's neither not constructive, nor friendly. Nothing about the contents of the page itself. You're basically, rude and borderline hostile with italics emphasizing something the author /should not/ do. Horrible. Where's your #1 Hacker News site? Where's your awesome collection of awesome sites that you shared with people. I don't see one.
- cheez 6y agouh.... what
- wolfgang42 6y agoI think it could maybe be worded a little more politely, but your comment seems far worse in that regard. At least the parent offers some advice about what to do instead.
- touchngthevodka 6y agoIt appears you are conflating criticism of the project with a personal attack on the user. There is a certain irony in your attempt to do so when you call the commenter an ass!
- HereBeBeasties 6y agoI found it concise, well-explained, informative and helpful. Hopefully many other people learned something useful from it. The author of the original site certainly got value from it given their reply. You don't always have to sugar coat code review feedback with a meaningless "This is awesome but..." - it's usually disingenuous at best. Surely as hackers we should all appreciate good, useful feedback like this?