3 ms·
Do you refer to shellcheck in general or in this specific case? I do a non-trivial amount of shell scripting, and there is only one warning I disable in shellc
by pizza234 6y ago
Do you refer to shellcheck in general or in this specific case?
I do a non-trivial amount of shell scripting, and there is only one warning I disable in shellcheck on a general basis (SC2016).
The author of this script clearly doesn't like quoting where the underlying value is guaranteed not to include special characters (or space), although this is somewhat inconsistent with the fact that he's using quotes in several patterns where it's not needed (eg. left or single operands in bash conditionals, or in variables initialization).
On can consider always quoting a defensive practice. In a fragile language like Bash, I personally think defensive practices are very important, so the first impression I get from a Bash program not adopting them is "not great".