4 ms·

I can't edit my comment, but the source code seems to be here: https://github.com/SymbianSource https://github.com/SymbianSource I could never accept the codin

I can't edit my comment, but the source code seems to be here: https://github.com/SymbianSource https://github.com/SymbianSource I could never accept the coding standard for curly bracket positioning.

brianpursley 6y ago
> I could never accept the coding standard for curly bracket positioning. OK, so I had to look. It's like they saw the two main camps (same line vs next line) and said "let's come up with something everyone will hate": TInt GetROMSize(TInt /*aDeviceNumber*/, TInt /*aAttrib*/, TBool /*aSet*/, TAny* aInOut) { TMemoryInfoV1 info; TPckg<TMemoryInfoV1> infoPckg(info); TInt r=UserSvr::HalFunction(EHalGroupKernel, EKernelHalMemoryInfo, (TAny*)&infoPckg, NULL); if (r==KErrNone) { *(TInt*)aInOut=info.iTotalRomInBytes; } return r; }
- perennialmind 6y ago
  Wow. I had a CS professor insist on exactly that style. I couldn't stand it at first, but making accommodations was the whole point. Unfortunately it got me thinking about what I would want. Now I'm the weirdo and I rarely get to write it the way I want. <shrug>
- mjevans 6y ago
  I can understand the desire to have the brackets at the same indent... but WOW does this break my brain having the inner code not indented from the bracket level. (I tend to prefer the opening backet being on the same line as the condition gate/guard and rely on the parser to inform me of missing brackets. This is even better in languages that have a single format convention.)
AceJohnny2 6y ago
> I could never accept the coding standard for curly bracket positioning. Hahaha, how bad could it be... ... Why the fuck would they need to indent every function by an 8-space tab!?
- AceJohnny2 6y ago
  I worked at STMicro for a while, and a neighboring team worked on Symbian support. I remember they had this weird coding standard that was essentially "why the fuck not?". Now, over a decade later, I understand that they looked at the Symbian standard, and saw that anything goes.
- nitrogen 6y ago
  8-space using the tab character is the Linux kernel standard, but the curly braces are closer to other coding standards.
  - AceJohnny2 6y ago
    It's not the 8-space I'm aghast about, but that every function body is indented by it.
app4soft 6y ago
There are few more places where you could grab Symbian sources.[0] [0] https://mrrosset.github.io/Symbian-Archive/Links.html https://mrrosset.github.io/Symbian-Archive/Links.html
SemiNormal 6y ago
Whitesmiths style is for sadists.
zerr 6y ago
Hah, I've worked on such styled legacy project from the European client. Seems like this style was popular in Europe during 90s :)

brianpursley 6y ago

> I could never accept the coding standard for curly bracket positioning. OK, so I had to look. It's like they saw the two main camps (same line vs next line) and said "let's come up with something everyone will hate": TInt GetROMSize(TInt /*aDeviceNumber*/, TInt /*aAttrib*/, TBool /*aSet*/, TAny* aInOut) { TMemoryInfoV1 info; TPckg<TMemoryInfoV1> infoPckg(info); TInt r=UserSvr::HalFunction(EHalGroupKernel, EKernelHalMemoryInfo, (TAny*)&infoPckg, NULL); if (r==KErrNone) { *(TInt*)aInOut=info.iTotalRomInBytes; } return r; }

perennialmind 6y ago
Wow. I had a CS professor insist on exactly that style. I couldn't stand it at first, but making accommodations was the whole point. Unfortunately it got me thinking about what I would want. Now I'm the weirdo and I rarely get to write it the way I want. <shrug>
mjevans 6y ago
I can understand the desire to have the brackets at the same indent... but WOW does this break my brain having the inner code not indented from the bracket level. (I tend to prefer the opening backet being on the same line as the condition gate/guard and rely on the parser to inform me of missing brackets. This is even better in languages that have a single format convention.)

AceJohnny2 6y ago

> I could never accept the coding standard for curly bracket positioning. Hahaha, how bad could it be... ... Why the fuck would they need to indent every function by an 8-space tab!?

AceJohnny2 6y ago
I worked at STMicro for a while, and a neighboring team worked on Symbian support. I remember they had this weird coding standard that was essentially "why the fuck not?". Now, over a decade later, I understand that they looked at the Symbian standard, and saw that anything goes.
nitrogen 6y ago
8-space using the tab character is the Linux kernel standard, but the curly braces are closer to other coding standards.
- AceJohnny2 6y ago
  It's not the 8-space I'm aghast about, but that every function body is indented by it.

app4soft 6y ago

There are few more places where you could grab Symbian sources.[0] [0] https://mrrosset.github.io/Symbian-Archive/Links.html https://mrrosset.github.io/Symbian-Archive/Links.html

SemiNormal 6y ago

Whitesmiths style is for sadists.

zerr 6y ago

Hah, I've worked on such styled legacy project from the European client. Seems like this style was popular in Europe during 90s :)