4 ms·
I'm not sure I understand why they revert the change. You get random small +/- changes in performance with the change, but you get slightly cleaner code. What's
by viraptor 6y ago
I'm not sure I understand why they revert the change. You get random small +/- changes in performance with the change, but you get slightly cleaner code. What's the reason not to want that?
- d_tr 6y agoI wondered the same. These are microbenchmarks after all and it does not even seem like a clear win.
- rybosworld 6y agoThey might be hesitant to check in a change that causes a behavior they don't understand. This is a good mindset imo.
- viraptor 6y agoI feel like there's a (sometimes blurry) line between being hesitant about dangerous changes (good thing) and hoping that if you ignore something you don't understand, it will keep working as you expect (not a good thing). Purely leaving an unused variable in place due to weird impact on performance is in the second category for me. But maybe there are other aspects - that's why I'm curious and asking about it
- nigeltao 6y agoSorry that the commit message wasn't clearer. Letting "foo" denote "wuffs_base__note__i_o_redirect", it wasn't really that "foo was unused", it was that "foo was unused, after the previous (artificial) commit renamed all-but-one of the foo references to another existing string constant". That previous commit set it up so that this commit, which exhibits the performance difference, has a trivially small diff. But the two commits combined to remove a "foo" that was actually in use, so the combination was rolled back. The previous commit is https://github.com/google/wuffs/commit/844fc9b5eeef46edab49c04516010db283e420da https://github.com/google/wuffs/commit/844fc9b5eeef46edab49c...