6 ms·
Oh my, it's a django app with debug mode enabled. I just got an InterfaceError with the full traceback and django configuration. (I've emailed them so they can
by lorenzhs 6y ago
Oh my, it's a django app with debug mode enabled. I just got an InterfaceError with the full traceback and django configuration. (I've emailed them so they can fix it)
- Hamuko 6y agoJust how in the world are people deploying Django apps with DEBUG = True?
- ChuckNorris89 6y agoSimple, human error and no code review process for your production environment. Something similar happened to a huge retailer here in Austria where just typing your username without password would log you in. Reason? An intern committed debug code to production and nobody noticed. In my book that's not the fault of the intern but the fault of the CTO/$TECH_LEAD that hasn't implemented and religiously uphold a code review process for everything that goes into production since stuff like this could happen even to experienced engineers that are tired or having a bad day.
- jfkebwjsbx 6y agoIt is the fault of both. Interns are not stupid and so they have to carry the burden of their mistakes too.
- kortilla 6y agoNo, absolutely not. As an engineer you develop systems and processes that don’t allow such major mistakes. You can’t fault people for making simple mistakes or you’ll end up with an organization where nothing gets done.
- jfkebwjsbx 6y agoEvery single human holding a responsibility at any level gets blame all the time. There is nothing wrong with that, nor with making mistakes, and it is a fact of life. Engineering processes are orthogonal to that.
- kernaussage 6y agoI live in Austria as well, could you share to which retailer it happened?
- deleted 6y ago[deleted]
- jbverschoor 6y agoIt shouldn’t be a manual code switch in the first place.
- ummonk 6y agoWhat else would it be? The authentication code would live somewhere. And for debugging someone could change it to always return successful for an empty password. That debugging change shouldn't be checked in of course, and it should have been caught in code review. (It's a reasonable oversight for the authentication unit tests to only test incorrect passwords rather than the edge case of empty passwords)
- deleted 6y ago[deleted]
- whatch 6y agoThat can happen when maintainers are professional scientists rather than professional web developers update: added "professional" before "scientists"
- Hamuko 6y agoBut you'd think they're still reading through Django's deployment documentation which explicitly states that you don't run DBEUG = True in production.
- acdha 6y agoI used to support scientists. I would not expect that unless you got the documentation published in a high-profile journal.
- cambalache 6y agoHeheh, from the guys who use variables such as Vo ,tm,max_p, this guy expect them to RTFM.
- ummonk 6y agoThose are perfectly reasonable names since they're standard convention in engineering and science. It's like using i, j, and k for index variables in iterators; the meaning is clear due to convention.
- antishatter 6y agoGood work!