3 ms·
While checking out the project on GitHub I noticed that you're using GerritHub for reviews and made me wonder whether this is holding back some people from cont
by eXpl0it3r 6y ago
While checking out the project on GitHub I noticed that you're using GerritHub for reviews and made me wonder whether this is holding back some people from contributing. Not that it's bad in anyway, but I assume it's something a lot of people are unfamiliar with and the description of how to use it for the project is very limited, plus work in progress isn't directly visible as PR on GitHub.
Additionally, you mention in the CONTRIBUTING.md that there's a Google doc with a lot of issues listed that should be converted to GitHub issues. Where does one find that Google doc?
- louniks 6y agoI'm not married to Gerrit, and I concede that it could be a hurdle. It's what I use for my day job, so I chose it out of laziness and familiarity more than anything else. I'll probably drop it, and learn the GitHub PR tools and workflow - I've gotten a few random PRs already. Edit: I'll talk to the volunteers about making that Google doc public, good suggestion.
- eXpl0it3r 6y agoI think one can go either way, but the important part is that it's clear to those willing to contribute. I think explaining a bit more how Gerrit reviews work and who is actually reviewing them, would already help, and maybe adding a link to the README, so it's easier discoverable. Cool, I wouldn't mind copying/creating a bunch of issues on the side.
- louniks 6y agoDone. https://github.com/LibriVox/librivox-catalog/blob/master/CONTRIBUTING.md https://github.com/LibriVox/librivox-catalog/blob/master/CON... Have fun, and many thanks! (I'll try to make time this weekend to drop GerritHub as well, and convert what I currently have there to PRs)