2 ms·
Why didn't code review catch this? If the review worked the way it's supposed to then you'd be one of the reviewers as you were the original author.
by sys_64738 6y ago
Why didn't code review catch this? If the review worked the way it's supposed to then you'd be one of the reviewers as you were the original author.
- mywittyname 6y agoOur setup was you needed one person to approve a merge request. These guys were buddies and would fast-track approvals. Also at that point, there were ~10 contributors to the code base, so things moved quickly. Other product within the company had a more formal code ownership structure, but this project was only two years old. So there were no owners, other than for infrastructure.