5 ms·

All I know is that I would not want to be the one who had last committed to production.

ridaj 6y ago
No, because, * You probably got a review on your change before it was submitted, so you weren't the only one to think it was an ok change to make * If you "revert first, ask questions later", you might also be the first one to fix it * Hopefully the team recognizes that there are higher-order causes that caused your submit to break things than your own personal skill
drubio 6y ago
Or the one in charge of testing. You'd think this is a day one unit test.
- jstanley 6y ago
  Right, which probably means the problem was quite subtle and was not detected by unit tests.
manquer 6y ago
Unlikely it is their logical app code , at this scale you likely will do canary releases or similar , failing for all users should be super rare It perhaps is related to devops or the search index cache servers is broken
- jonny_eh 6y ago
  Or a bad config. 90% of the time it's a bad config.
cvik 6y ago
Good teams don't blame individuals. You can praise individuals, but you take blame as a team. Hopefully at least two people reviewed the commit before it was put into production. Someone set up the post-launch smoke-tests/api-test-suits. Someone built the CI/CD-system. Etc etc. My point is, it is rarely a single individuals fault when something at this scale goes down.
- jilles 6y ago
  >Good teams don't blame individuals. You can praise individuals, but you take blame as a team. I could not agree more with this statement.
- godelski 6y ago
  I also think a lot of praise should generally be a team thing too (but I also love this: "You can praise individuals, but you take blame as a team.") When discussing success to an outside group (giving a presentation or something) or higher up (especially here!) you always use "we". Even if it is a section that only you worked on or you did most of the work. You can often pick out good managers by just seeing if they talk like this, if their focus is around what they individually did or what their team accomplished. My point is, it is rarely a single individual's success when things work.
  - cvik 6y ago
    I agree with everything you say.
  - nitrogen 6y ago
    I also really like it when managers mention significant individuals (as suggested by the phrasing that started this thread), as long as everyone on the team is getting mention-worthy projects. Both group and individual recognition, as long as it's fairly used.
    - godelski 6y ago
      Yes, exactly. I don't want to downplay the importance of praising individuals, but at the same time I don't want it to shadow praising teams. There's a balance and I do think we tend to focus on the individual as a society. We can only climb mountains by standing on the shoulders of giants. One person gets to the peak and we should praise them for that, but we shouldn't ignore their foundation either (which I think currently happens). E.G. Kepler was an essential part of science and needs to be recognized, but if it wasn't for the work that Tycho Brahe did, Kepler's achievements couldn't exist. The "single person" mentality ignores the importance of the foundational work that needed to be done and frequently causes many to feel that they are not achieving simply because they are working in these roles, which are essential.

No, because, * You probably got a review on your change before it was submitted, so you weren't the only one to think it was an ok change to make * If you "revert first, ask questions later", you might also be the first one to fix it * Hopefully the team recognizes that there are higher-order causes that caused your submit to break things than your own personal skill

drubio 6y ago

Or the one in charge of testing. You'd think this is a day one unit test.

jstanley 6y ago
Right, which probably means the problem was quite subtle and was not detected by unit tests.

manquer 6y ago

Unlikely it is their logical app code , at this scale you likely will do canary releases or similar , failing for all users should be super rare It perhaps is related to devops or the search index cache servers is broken

jonny_eh 6y ago
Or a bad config. 90% of the time it's a bad config.

cvik 6y ago

Good teams don't blame individuals. You can praise individuals, but you take blame as a team. Hopefully at least two people reviewed the commit before it was put into production. Someone set up the post-launch smoke-tests/api-test-suits. Someone built the CI/CD-system. Etc etc. My point is, it is rarely a single individuals fault when something at this scale goes down.

jilles 6y ago
>Good teams don't blame individuals. You can praise individuals, but you take blame as a team. I could not agree more with this statement.
godelski 6y ago
I also think a lot of praise should generally be a team thing too (but I also love this: "You can praise individuals, but you take blame as a team.") When discussing success to an outside group (giving a presentation or something) or higher up (especially here!) you always use "we". Even if it is a section that only you worked on or you did most of the work. You can often pick out good managers by just seeing if they talk like this, if their focus is around what they individually did or what their team accomplished. My point is, it is rarely a single individual's success when things work.
- cvik 6y ago
  I agree with everything you say.
- nitrogen 6y ago
  I also really like it when managers mention significant individuals (as suggested by the phrasing that started this thread), as long as everyone on the team is getting mention-worthy projects. Both group and individual recognition, as long as it's fairly used.
  - godelski 6y ago
    Yes, exactly. I don't want to downplay the importance of praising individuals, but at the same time I don't want it to shadow praising teams. There's a balance and I do think we tend to focus on the individual as a society. We can only climb mountains by standing on the shoulders of giants. One person gets to the peak and we should praise them for that, but we shouldn't ignore their foundation either (which I think currently happens). E.G. Kepler was an essential part of science and needs to be recognized, but if it wasn't for the work that Tycho Brahe did, Kepler's achievements couldn't exist. The "single person" mentality ignores the importance of the foundational work that needed to be done and frequently causes many to feel that they are not achieving simply because they are working in these roles, which are essential.