3 ms·
They have code review post-commit? It seems like a very dangerous practice. How do you guys feel about it?
by sdizdar 16y ago
They have code review post-commit? It seems like a very dangerous practice. How do you guys feel about it?
- woan 16y agoWith a team this size, I think it's spot on given their caveats: http://www.quora.com/Does-Quora-engineering-use-a-code-review-process http://www.quora.com/Does-Quora-engineering-use-a-code-revie... I assume they have a culture of shame and pride for power and responsibility afforded to each developer.
- kahseng 16y agoWe also do pre-commit reviews for the important stuff, especially things related to privacy and anonymity. We know when to do them pre-commit or post (which is the norm).