3 ms·
Do one thing at a time, well, and track outcomes. Be prepared to take responsibility for it. Code review is a practice that has studies which demonstrate that
by agentultra 6y ago
Do one thing at a time, well, and track outcomes.
Be prepared to take responsibility for it.
Code review is a practice that has studies which demonstrate that it's effective at reducing errors in software [0].
Work on that at first. Be prepared to spend a good amount of your time doing most of the code reviews. Write a review guideline with your team and share it around. Once people get used to the habit start encouraging others to take some of the responsibility.
I encountered a similar situation. Nobody practiced code review. Test coverage was spartan and brittle. The company was focused on shipping the first thing that worked, fast. Maybe it was to keep the lights on and land those precious contracts... but it had the external effect of tightly coupled systems, increased error rates and support requests, and in some cases errors resulted in customers losing data.
When changing culture and habits you have to be patient and resilient.
It took about a year before code review became widely adopted on the team. About six months after that we started tracking our code review metrics as we found that pull requests with few comments and large amounts of change were a big risk. We started getting feedback from reviewers that changes over a certain size were slowing down our velocity so we started seeing people submit smaller, leaner changes.
I did the same thing with testing. We now trust our CI pipeline to manage our code quality and releases. We're working on CD. It started small. And it grew.
You're not unreasonable. And neither is the team you're working with. Manage expectations and be the change you want to see and be patient.
[0] https://sail.cs.queensu.ca/Downloads/EMSE_AnEmpiricalStudyOfTheImpactOfModernCodeReviewPracticesOnSoftwareQuality.pdf https://sail.cs.queensu.ca/Downloads/EMSE_AnEmpiricalStudyOf...